linux-kernel - Re: [PATCH v2 16/22] wifi: ath12k: convert tasklet to BH workqueue for CE interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877ca1q0yq.fsf@kernel.org>
Date: Mon, 21 Oct 2024 12:06:37 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
Cc: <ath12k@...ts.infradead.org>,  <linux-wireless@...r.kernel.org>,  "Rob
 Herring" <robh@...nel.org>,  Krzysztof Kozlowski <krzk+dt@...nel.org>,
  "Conor Dooley" <conor+dt@...nel.org>,  Jeff Johnson
 <jjohnson@...nel.org>,  "Bjorn Andersson" <andersson@...nel.org>,  Konrad
 Dybcio <konradybcio@...nel.org>,  <devicetree@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>,  <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v2 16/22] wifi: ath12k: convert tasklet to BH workqueue
 for CE interrupts

Raj Kumar Bhagat <quic_rajkbhag@...cinc.com> writes:

> Currently in Ath12k, tasklet is used to handle the BH context of CE
> interrupts. However the tasklet is marked deprecated and has some
> design flaws. To replace tasklets, BH workqueue support has been
> added. BH workqueue behaves similarly to regular workqueues except
> that the queued work items are executed in the BH context.
>
> Hence, convert the tasklet to BH workqueue for handling CE interrupts
> in the BH context.
>
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>

22 patches is a lot and I'm not going to look at this in detail, please
reduce your patchset size. 10-12 patches is recommended. For example,
this could be easily submitted separately.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches