linux-kernel - Re: [PATCH v1 1/2] dt-bindings: serial: samsung: Add samsung,exynos8895-uart compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09c1e8a0-f669-42ef-bbd2-44649fad35d8@kernel.org>
Date: Mon, 21 Oct 2024 11:29:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: serial: samsung: Add
 samsung,exynos8895-uart compatible

On 20/10/2024 20:02, Ivaylo Ivanov wrote:
> Add dedicated samsung,exynos8895-uart compatible to the dt-schema for
> representing uart of the Exynos8895 SoC.
> 
> Like GS101, it has a required DT property samsung,uart-fifosize, but
> it does not exhibit the 32 bit register access limit.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> ---
>  .../bindings/serial/samsung_uart.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index 788c80e47..2491b6048 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -27,6 +27,7 @@ properties:
>            - samsung,exynos4210-uart
>            - samsung,exynos5433-uart
>            - samsung,exynos850-uart
> +          - samsung,exynos8895-uart
>        - items:
>            - enum:
>                - samsung,exynos7-uart
> @@ -172,6 +173,22 @@ allOf:
>          clock-names:
>            maxItems: 2
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - samsung,exynos8895-uart

This looks exactly like gs101, so please grow the enum there.

Best regards,
Krzysztof