linux-kernel - Re: [PATCH] dt-bindings: input: Goodix SPI HID Touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89e22cf5-5247-4218-8757-d34253fbfe37@kernel.org>
Date: Mon, 21 Oct 2024 11:41:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charles Wang <charles.goodix@...il.com>, dmitry.torokhov@...il.com,
 hbarnor@...omium.org, dianders@...omium.org, conor.dooley@...rochip.com
Cc: jikos@...nel.org, bentiss@...nel.org, linux-input@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: input: Goodix SPI HID Touchscreen

On 19/10/2024 04:46, Charles Wang wrote:
>>>>> +  goodix,hid-report-addr:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>> +    description:
>>>>> +      The register address for retrieving HID report data.
>>>>> +      This address is related to the device firmware and may
>>>>> +      change after a firmware update.
>>>>
> 
>> How is this supposed to work? DTS will stay fixed, you cannot change it
>> just because firmware changed. User loads new firmware with different
>> address, but DTS will have to use old address - so broken property.
>>
> 
> Sorry for missing this issue in my previous response.
> Honestly, although the likelihood of this address changing is low, it is
> indeed possible for it to change due to a firmware update during the factory
> debugging phase. However, for machines that users have, we will ensure that
> this address will not be altered as a result of a firmware upgrade.

Then it feels like property is not really needed - all boards will have
exactly same value.

Best regards,
Krzysztof