linux-kernel - Re: [PATCH] platform/x86: dell-dcdbase: Replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49db5473-c7cc-b4e5-6166-cb56ba3dd7b0@linux.intel.com>
Date: Mon, 21 Oct 2024 13:53:59 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Hongling Zeng <zenghongling@...inos.cn>
cc: LKML <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org, 
    stuart.w.hayes@...il.com, Hans de Goede <hdegoede@...hat.com>, 
    zhongling0719@....com
Subject: Re: [PATCH] platform/x86: dell-dcdbase: Replace snprintf in show 
 functions with sysfs_emit

On Mon, 21 Oct 2024, Hongling Zeng wrote:

>   show() must not use snprintf() when formatting the value to be

Please remove the extra spaces.

> returned to user space

Missing .

> Signed-off-by: Hongling Zeng <zenghongling@...inos.cn>
> ---
>  drivers/platform/x86/dell/dcdbas.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
> index a60e350..143fd0a 100644
> --- a/drivers/platform/x86/dell/dcdbas.c
> +++ b/drivers/platform/x86/dell/dcdbas.c
> @@ -132,14 +132,14 @@ static ssize_t smi_data_buf_phys_addr_show(struct device *dev,
>  					   struct device_attribute *attr,
>  					   char *buf)
>  {

Add #include <linux/sysfs.h> (I did this for you in the other patch when 
I realized it's missing).

Once you've fixed those 3 issues mentioned above, please send v2.

-- 
 i.

> -	return sprintf(buf, "%x\n", (u32)smi_buf.dma);
> +	return sysfs_emit(buf, "%x\n", (u32)smi_buf.dma);
>  }
>  
>  static ssize_t smi_data_buf_size_show(struct device *dev,
>  				      struct device_attribute *attr,
>  				      char *buf)
>  {
> -	return sprintf(buf, "%lu\n", smi_buf.size);
> +	return sysfs_emit(buf, "%lu\n", smi_buf.size);
>  }
>  
>  static ssize_t smi_data_buf_size_store(struct device *dev,
> @@ -200,7 +200,7 @@ static ssize_t host_control_action_show(struct device *dev,
>  					struct device_attribute *attr,
>  					char *buf)
>  {
> -	return sprintf(buf, "%u\n", host_control_action);
> +	return sysfs_emit(buf, "%u\n", host_control_action);
>  }
>  
>  static ssize_t host_control_action_store(struct device *dev,
> @@ -224,7 +224,7 @@ static ssize_t host_control_smi_type_show(struct device *dev,
>  					  struct device_attribute *attr,
>  					  char *buf)
>  {
> -	return sprintf(buf, "%u\n", host_control_smi_type);
> +	return sysfs_emit(buf, "%u\n", host_control_smi_type);
>  }
>  
>  static ssize_t host_control_smi_type_store(struct device *dev,
> @@ -239,7 +239,7 @@ static ssize_t host_control_on_shutdown_show(struct device *dev,
>  					     struct device_attribute *attr,
>  					     char *buf)
>  {
> -	return sprintf(buf, "%u\n", host_control_on_shutdown);
> +	return sysfs_emit(buf, "%u\n", host_control_on_shutdown);
>  }
>  
>  static ssize_t host_control_on_shutdown_store(struct device *dev,
>