linux-kernel - Re: [PATCH v2] dt-bindings: hwmon: pmbus: Add bindings for Vicor pli1209bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172951032336.3278738.7867634069843302759.robh@kernel.org>
Date: Mon, 21 Oct 2024 06:32:03 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: jdelvare@...e.com, linux-kernel@...r.kernel.org, linux@...ck-us.net, 
 devicetree@...r.kernel.org, sylv@...v.io, linux-hwmon@...r.kernel.org, 
 conor+dt@...nel.org, krzk+dt@...nel.org
Subject: Re: [PATCH v2] dt-bindings: hwmon: pmbus: Add bindings for Vicor
 pli1209bc


On Mon, 21 Oct 2024 14:44:29 +0530, Naresh Solanki wrote:
> Remove vicor,pli1209bc from trivial-devices as it requires additional
> properties and does not fit into the trivial devices category.
> 
> Add new bindings for Vicor pli1209bc, a Digital Supervisor with
> Isolation for use with BCM Bus Converter Modules.
> 
> VR rails are defined under regulator node as expected by pmbus driver.
> 
> Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
> ---
> Changes in V2:
> - Squash the two patch in patch into one.
> - Update commit message.
> ---
>  .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 62 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  2 -
>  2 files changed, 62 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml: properties: 'additionalProperties' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
	hint: A json-schema keyword was found instead of a DT property name.
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml: regulators: Missing additionalProperties/unevaluatedProperties constraint

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241021091430.3489816-1-naresh.solanki@9elements.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.