[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZxXFICl573EOMWQX@dragon>
Date: Mon, 21 Oct 2024 11:06:08 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] arm64: dts: imx8qxp-mek: add cm4 and related nodes
On Mon, Sep 30, 2024 at 05:26:03PM -0400, Frank Li wrote:
> Add cm4 and related nodes.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index bbb94adfd64f0..83e8393a34a0c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -21,6 +21,21 @@ chosen {
> stdout-path = &lpuart0;
> };
>
> + imx8x_cm4: imx8x_cm4 {
Hyphen instead of underscore in node name.
> + compatible = "fsl,imx8qxp-cm4";
> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&lsio_mu5 0 1
> + &lsio_mu5 1 1
> + &lsio_mu5 3 1>;
> + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
> + <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
> + power-domains = <&pd IMX_SC_R_M4_0_PID0>,
> + <&pd IMX_SC_R_M4_0_MU_1A>;
> + fsl,entry-address = <0x34fe0000>;
> + fsl,resource-id = <IMX_SC_R_M4_0_PID0>;
> + status = "okay";
> + };
> +
> memory@...00000 {
> device_type = "memory";
> reg = <0x00000000 0x80000000 0 0x40000000>;
> @@ -85,6 +100,48 @@ reg_usb_otg1_vbus: regulator-usbotg1-vbus {
> enable-active-high;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + vdev0vring0: memory@...00000 {
> + reg = <0 0x90000000 0 0x8000>;
> + no-map;
> + };
> +
> + vdev0vring1: memory@...08000 {
> + reg = <0 0x90008000 0 0x8000>;
> + no-map;
> + };
> +
> + vdev1vring0: memory@...10000 {
> + reg = <0 0x90010000 0 0x8000>;
> + no-map;
> + };
> +
> + vdev1vring1: memory@...18000 {
> + reg = <0 0x90018000 0 0x8000>;
> + no-map;
> + };
> +
> + rsc_table: memory@...ff000 {
> + reg = <0 0x900ff000 0 0x1000>;
> + no-map;
> + };
> +
> + vdevbuffer: memory@...00000 {
> + compatible = "shared-dma-pool";
Use tabs instead of spaces for indent.
> + reg = <0 0x90400000 0 0x100000>;
> + no-map;
> + };
> +
> + gpu_reserved: gpu_reserved@...000000 {
"memory" for node name?
Shawn
> + no-map;
> + reg = <0x8 0x80000000 0 0x10000000>;
> + };
> + };
> +
> sound-bt-sco {
> compatible = "simple-audio-card";
> simple-audio-card,bitclock-inversion;
> @@ -407,6 +464,10 @@ &lpuart3 {
> status = "okay";
> };
>
> +&lsio_mu5 {
> + status = "okay";
> +};
> +
> &mu_m0 {
> status = "okay";
> };
> --
> 2.34.1
>
Powered by blists - more mailing lists