linux-kernel - Re: [PATCH net-next v3] net: Implement fault injection forcing skb reallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxZKkY8U4jndx8no@archie.me>
Date: Mon, 21 Oct 2024 19:35:29 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Breno Leitao <leitao@...ian.org>, Akinobu Mita <akinobu.mita@...il.com>,
	Jonathan Corbet <corbet@....net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc: kernel-team@...a.com, Pavel Begunkov <asml.silence@...il.com>,
	Mina Almasry <almasrymina@...gle.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Linux Documentation <linux-doc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] net: Implement fault injection forcing skb
 reallocation

On Mon, Oct 14, 2024 at 06:50:00AM -0700, Breno Leitao wrote:
> +  To select the interface to act on, write the network name to the following file:
> +  `/sys/kernel/debug/fail_net_force_skb_realloc/devname`
"... write the network name to /sys/kernel/debug/fail_net_force_skb_realloc/devname."
> +  If this field is left empty (which is the default value), skb reallocation
> +  will be forced on all network interfaces.
> +
> <snipped>...
> +- /sys/kernel/debug/fail_net_force_skb_realloc/devname:
> +
> +        Specifies the network interface on which to force SKB reallocation.  If
> +        left empty, SKB reallocation will be applied to all network interfaces.
> +
> +        Example usage:
> +        # Force skb reallocation on eth0
> +        echo "eth0" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
> +
> +        # Clear the selection and force skb reallocation on all interfaces
> +        echo "" > /sys/kernel/debug/fail_net_force_skb_realloc/devname

The examples rendered as normal paragraph instead (and look like long-running
sentences) so I wrap them in literal code blocks:

---- >8 ----
diff --git a/Documentation/fault-injection/fault-injection.rst b/Documentation/fault-injection/fault-injection.rst
index bb19638d53171b..b2bf3afd16d144 100644
--- a/Documentation/fault-injection/fault-injection.rst
+++ b/Documentation/fault-injection/fault-injection.rst
@@ -243,12 +243,13 @@ configuration of fault-injection capabilities.
         Specifies the network interface on which to force SKB reallocation.  If
         left empty, SKB reallocation will be applied to all network interfaces.
 
-        Example usage:
-        # Force skb reallocation on eth0
-        echo "eth0" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
+        Example usage::
 
-        # Clear the selection and force skb reallocation on all interfaces
-        echo "" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
+          # Force skb reallocation on eth0
+          echo "eth0" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
+
+          # Clear the selection and force skb reallocation on all interfaces
+          echo "" > /sys/kernel/debug/fail_net_force_skb_realloc/devname
 
 Boot option
 ^^^^^^^^^^^

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)