lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <135dcf22-bfd1-4624-958c-599f0f3d49dc@amd.com>
Date: Mon, 21 Oct 2024 18:45:54 +0530
From: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
To: Mario Limonciello <mario.limonciello@....com>,
 "Gautham R . Shenoy" <gautham.shenoy@....com>
Cc: Perry Yuan <perry.yuan@....com>, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH] cpufreq/amd-pstate-ut: Add fix for min freq unit test

Hello Mario,

On 10/17/2024 11:04 PM, Mario Limonciello wrote:
> commit 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to
> lowest_nonlinear_freq") changed the iniital minimum frequency to lowest
> nonlinear frequency, but the unit tests weren't updated and now fail.
> 
> Update them to match this same change.

Thanks for the fix, looks good to me.

Regards,
Dhananjay

> 
> Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/cpufreq/amd-pstate-ut.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index f66701514d906..a261d7300951e 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -227,10 +227,10 @@ static void amd_pstate_ut_check_freq(u32 index)
>  			goto skip_test;
>  		}
>  
> -		if (cpudata->min_freq != policy->min) {
> +		if (cpudata->lowest_nonlinear_freq != policy->min) {
>  			amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
> -			pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d, they should be equal!\n",
> -				__func__, cpu, cpudata->min_freq, policy->min);
> +			pr_err("%s cpu%d cpudata_lowest_nonlinear_freq=%d policy_min=%d, they should be equal!\n",
> +				__func__, cpu, cpudata->lowest_nonlinear_freq, policy->min);
>  			goto skip_test;
>  		}
>  

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ