linux-kernel - Re: [PATCH v2] btrfs: Fix passing 0 to ERR_PTR in btrfs_search_dir_index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241022134821.GC31418@suse.cz>
Date: Tue, 22 Oct 2024 15:48:22 +0200
From: David Sterba <dsterba@...e.cz>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: clm@...com, josef@...icpanda.com, Johannes.Thumshirn@....com,
	dsterba@...e.com, mpdesouza@...e.com, gniebler@...e.com,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] btrfs: Fix passing 0 to ERR_PTR in
 btrfs_search_dir_index_item()

On Tue, Oct 22, 2024 at 05:52:08PM +0800, Yue Haibing wrote:
> ret may be zero in btrfs_search_dir_index_item() and should not passed
> to ERR_PTR(). Now btrfs_unlink_subvol() is the only caller to this,
> reconstructed it to check ERR_PTR(-ENOENT) while ret >= 0, this fix
> smatch warnings:
> 
> fs/btrfs/dir-item.c:353
>  btrfs_search_dir_index_item() warn: passing zero to 'ERR_PTR'
> 
> Fixes: 9dcbe16fccbb ("btrfs: use btrfs_for_each_slot in btrfs_search_dir_index_item")
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
> v2: return ERR_PTR(-ENOENT) while ret >= 0

Reviewed-by: David Sterba <dsterba@...e.com>

Added to for-next, thanks.