linux-kernel - Re: [PATCH v6 2/2] hwmon: Add driver for I2C chip Nuvoton NCT7363Y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6846ac5-55ee-405c-939b-1199ea362fb5@roeck-us.net>
Date: Tue, 22 Oct 2024 08:14:15 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, baneric926@...il.com,
 jdelvare@...e.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, corbet@....net
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 openbmc@...ts.ozlabs.org, kwliu@...oton.com, kcfeng0@...oton.com,
 DELPHINE_CHIU@...ynn.com, Bonnie_Lo@...ynn.com
Subject: Re: [PATCH v6 2/2] hwmon: Add driver for I2C chip Nuvoton NCT7363Y

On 10/22/24 00:20, Christophe JAILLET wrote:
[ ... ]
>> +    hwmon_dev =
>> +        devm_hwmon_device_register_with_info(dev, client->name, data,
>> +                             &nct7363_chip_info, NULL);
> 
> return devm_hwmon_device_register_with_info()?
> 

No, because the function needs to return an integer, not a pointer.
And
	return PTR_ERR_OR_ZERO(devm_hwmon_device_register_with_info(...));
would look a bit awkward.

Guenter