linux-kernel - Re: [PATCH 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241022-prayer-unmanaged-86ea24caf242@spud>
Date: Tue, 22 Oct 2024 17:54:59 +0100
From: Conor Dooley <conor@...nel.org>
To: Jason-Hsu <jasonhell19@...il.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	joel@....id.au, andrew@...econstruct.com.au, patrick@...cx.xyz,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	yang.chen@...ntatw.com, jerry.lin@...ntatw.com
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC

On Tue, Oct 22, 2024 at 05:51:45PM +0100, Conor Dooley wrote:
> On Tue, Oct 22, 2024 at 10:17:24AM +0800, Jason-Hsu wrote:
> > Add Linux device tree related to Meta(Facebook) Ventura specific devices connected to BMC(AST2600) SoC.
> > Add subject prefix for the patch.
> > 
> > Signed-off-by: Jason-Hsu <jasonhell19@...il.com>
> 
> The indentation in here is very inconsistent. Please fix that.

Also, I don't know what the coding style in aspeed in particular is, but
the node ordering seems very random here. Could you sort nodes in the
dts alphanumerically as the dts coding style suggests?


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)