linux-kernel - Re: [PATCH v2 4/5] x86/cpu: Add CPU type to struct cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf577663-b160-4d89-825d-864d87a16a45@intel.com>
Date: Tue, 22 Oct 2024 10:09:25 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Mario Limonciello <mario.limonciello@....com>,
 Borislav Petkov <bp@...en8.de>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H . Peter Anvin" <hpa@...or.com>, "Rafael J . Wysocki" <rafael@...nel.org>,
 "Gautham R . Shenoy" <gautham.shenoy@....com>,
 Perry Yuan <perry.yuan@....com>, Brijesh Singh <brijesh.singh@....com>,
 Peter Zijlstra <peterz@...radead.org>, Li RongQing <lirongqing@...du.com>,
 "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
 <linux-kernel@...r.kernel.org>, "open list:ACPI"
 <linux-acpi@...r.kernel.org>,
 "open list:AMD PSTATE DRIVER" <linux-pm@...r.kernel.org>,
 Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
Subject: Re: [PATCH v2 4/5] x86/cpu: Add CPU type to struct cpuinfo_topology

On 10/22/24 09:13, Mario Limonciello wrote:
> On 10/22/2024 11:03, Dave Hansen wrote:
...
>> Having:
>>
>>     TOPO_CPU_TYPE_EFFICIENCY, and
>>     TOPO_CPU_TYPE_PERFORMANCE
>>
>> is totally fine in generic code.  But we also need to preserve the:
>>
>>     TOPO_HW_CPU_TYPE_INTEL_ATOM
>>     TOPO_HW_CPU_TYPE_INTEL_CORE
>>
>> values also for use in vendor-specific code.
> 
> What you're suggesting is to keep an enum in the intel.c code and any
> code that needs to match atom vs core can directly use
> 
> c->topo.intel_type == TOPO_HW_CPU_TYPE_INTEL_ATOM
> 
> Right?

Yep, exactly.

> As it stands today none of this is exported anywhere but debugfs; so
> I wouldn't say we have ABI concerns (yet).  Could we wait until the
> one that breaks the mold shows up?

Oh, debugfs is fine.  I was, for some reason, assuming that the strings
were getting spit out in sysfs proper somewhere, not debugfs.  Sorry for
the noise.