| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241022-crisply-brute-45f98632ef78@spud>
Date: Tue, 22 Oct 2024 18:28:06 +0100
From: Conor Dooley <conor@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Chen Wang <unicorn_wang@...look.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Inochi Amaoto <inochiama@...look.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Richard Cochran <richardcochran@...il.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Yixun Lan <dlan@...too.org>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac
On Mon, Oct 21, 2024 at 06:36:15PM +0800, Inochi Amaoto wrote:
> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC
> with some extra clock.
>
> Add necessary compatible string for this device.
>
> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
> .../bindings/net/sophgo,sg2044-dwmac.yaml | 145 ++++++++++++++++++
> 2 files changed, 146 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 3c4007cb65f8..69f6bb36970b 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -99,6 +99,7 @@ properties:
> - snps,dwmac-5.30a
> - snps,dwxgmac
> - snps,dwxgmac-2.10
> + - sophgo,sg2044-dwmac
> - starfive,jh7100-dwmac
> - starfive,jh7110-dwmac
>
> diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> new file mode 100644
> index 000000000000..93c41550b0b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> @@ -0,0 +1,145 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/sophgo,sg2044-dwmac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive JH7110 DWMAC glue layer
> +
> +maintainers:
> + - Inochi Amaoto <inochiama@...il.com>
> +
> +select:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - sophgo,sg2044-dwmac
> + required:
> + - compatible
> +
> +properties:
> + compatible:
> + items:
> + - const: sophgo,sg2044-dwmac
> + - const: snps,dwmac-5.30a
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: GMAC main clock
> + - description: PTP clock
> + - description: TX clock
> +
> + clock-names:
> + items:
> + - const: stmmaceth
> + - const: ptp_ref
> + - const: tx
> +
> + sophgo,syscon:
How many dwmac instances does the sg2044 have?
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to syscon that configures phy
> + - description: offset of phy mode register
> + - description: length of the phy mode register
> + description:
> + A phandle to syscon with two arguments that configure phy mode.
> + The argument one is the offset of phy mode register, the
> + argument two is the length of phy mode register.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - interrupt-names
> + - resets
> + - reset-names
> +
> +allOf:
> + - $ref: snps,dwmac.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: sophgo,sg2044-dwmac
Why does this have to be applied conditionally? There's only one
compatible in the binding, can't you apply these unconditionally?
Cheers,
Conor.
> + then:
> + properties:
> + interrupts:
> + minItems: 1
> + maxItems: 1
> +
> + interrupt-names:
> + minItems: 1
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: stmmaceth
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + ethernet@...06000 {
> + compatible = "sophgo,sg2044-dwmac", "snps,dwmac-5.30a";
> + reg = <0x30006000 0x4000>;
> + clocks = <&clk 151>, <&clk 152>, <&clk 154>;
> + clock-names = "stmmaceth", "ptp_ref", "tx";
> + interrupt-parent = <&intc>;
> + interrupts = <296 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq";
> + resets = <&rst 30>;
> + reset-names = "stmmaceth";
> + snps,multicast-filter-bins = <0>;
> + snps,perfect-filter-entries = <1>;
> + snps,aal;
> + snps,tso;
> + snps,txpbl = <32>;
> + snps,rxpbl = <32>;
> + snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> + snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> + snps,axi-config = <&gmac0_stmmac_axi_setup>;
> + status = "disabled";
> +
> + gmac0_mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <8>;
> + snps,rx-sched-wsp;
> + queue0 {};
> + queue1 {};
> + queue2 {};
> + queue3 {};
> + queue4 {};
> + queue5 {};
> + queue6 {};
> + queue7 {};
> + };
> +
> + gmac0_mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <8>;
> + queue0 {};
> + queue1 {};
> + queue2 {};
> + queue3 {};
> + queue4 {};
> + queue5 {};
> + queue6 {};
> + queue7 {};
> + };
> +
> + gmac0_stmmac_axi_setup: stmmac-axi-config {
> + snps,blen = <16 8 4 0 0 0 0>;
> + snps,wr_osr_lmt = <1>;
> + snps,rd_osr_lmt = <2>;
> + };
> + };
> --
> 2.47.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists