linux-kernel - Re: [PATCH v2 2/2] mm/damon/vaddr: Add 'nr_piece == 1' check in damon_va_evenly_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241022175710.42308-1-sj@kernel.org>
Date: Tue, 22 Oct 2024 10:57:10 -0700
From: SeongJae Park <sj@...nel.org>
To: Zheng Yejian <zhengyejian@...weicloud.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	foersleo@...zon.de,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	shakeel.butt@...ux.dev,
	sieberf@...zon.com,
	yeweihua4@...wei.com,
	brendanhiggins@...gle.com,
	davidgow@...gle.com,
	rmoar@...gle.com,
	linux-kselftest@...r.kernel.org,
	kunit-dev@...glegroups.com
Subject: Re: [PATCH v2 2/2] mm/damon/vaddr: Add 'nr_piece == 1' check in damon_va_evenly_split_region()

Hi Zheng,


Cc-ed kunit folks, as we usually do for DAMON kunit test changes.

On Tue, 22 Oct 2024 16:39:27 +0800 Zheng Yejian <zhengyejian@...weicloud.com> wrote:

> As discussed in [1], damon_va_evenly_split_region() is called to
> size-evenly split a region into 'nr_pieces' small regions,
> when nr_pieces == 1, no actual split is required. Check that case
> for better code readability and add a simple kunit testcase.
> 
> [1] https://lore.kernel.org/all/20241021163316.12443-1-sj@kernel.org/
> 
> Signed-off-by: Zheng Yejian <zhengyejian@...weicloud.com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]