linux-kernel - Re: [PATCH] usb: typec: tcpci: Add FAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CALzBnUHxA8MTHyuWhOOF8GOoohsSz9KN54Aw=CiiJiu9Jz_Bew@mail.gmail.com>
Date: Tue, 22 Oct 2024 11:01:38 -0700
From: RD Babiera <rdbabiera@...gle.com>
To: Yanik Fuchs <Yanik.fuchs@....ch>
Cc: "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>, 
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, 
	"m.felsch@...gutronix.de" <m.felsch@...gutronix.de>, 
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>, 
	Emanuele Ghidoli <emanuele.ghidoli@...adex.com>, 
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: typec: tcpci: Add FAULT_ALERT handling

Hi Yanik,

> +   /*
> +   * some chips asert fault alert, even if it is masked.
> +   * The FAULT_STATUS is read and
> +   */
> +   if (status & TCPC_ALERT_FAULT)
> +       regmap_read(tcpci->regmap, TCPC_FAULT_STATUS, &raw);
> +       regmap_write(tcpci->regmap, TCPC_FAULT_STATUS, raw);

Would it make sense to register TCPC_ALERT_FAULT to the alert mask as well?
If TCPC_ALERT_FAULT would be the only alert to trigger an IRQ, will tcpci_irq
still run if it is masked? i.e., can this patch only read/clear the
fault status because
it piggybacks off of another alert?

Best,
RD