linux-kernel - RE: [PATCH] hexagon: Move kernel prototypes out of uapi/asm/setup.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DS0PR02MB10250CAA28A6119B7C9F0767BB84C2@DS0PR02MB10250.namprd02.prod.outlook.com>
Date: Tue, 22 Oct 2024 19:19:10 +0000
From: Brian Cain <bcain@...cinc.com>
To: Thomas Huth <thuth@...hat.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd
 Bergmann <arnd@...db.de>,
        "linux-arch@...r.kernel.org"
	<linux-arch@...r.kernel.org>,
        "linux-hexagon@...r.kernel.org"
	<linux-hexagon@...r.kernel.org>
Subject: RE: [PATCH] hexagon: Move kernel prototypes out of uapi/asm/setup.h
 header



> -----Original Message-----
> From: Thomas Huth <thuth@...hat.com>
> Sent: Tuesday, October 22, 2024 1:44 PM
> To: Brian Cain <bcain@...cinc.com>
> Cc: linux-kernel@...r.kernel.org; Arnd Bergmann <arnd@...db.de>; linux-
> arch@...r.kernel.org; linux-hexagon@...r.kernel.org
> Subject: Re: [PATCH] hexagon: Move kernel prototypes out of
> uapi/asm/setup.h header
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> On 02/05/2024 19.38, Thomas Huth wrote:
> > The kernel function prototypes are of no use for userspace and
> > shouldn't get exposed in an uapi header, so let's move them into
> > an internal header instead.
> >
> > Signed-off-by: Thomas Huth <thuth@...hat.com>
> > ---

Reviewed-by: Brian Cain <bcain@...cinc.com>

> >   arch/hexagon/include/asm/setup.h      | 20 ++++++++++++++++++++
> >   arch/hexagon/include/uapi/asm/setup.h | 14 ++------------
> >   2 files changed, 22 insertions(+), 12 deletions(-)
> >   create mode 100644 arch/hexagon/include/asm/setup.h
> >
> > diff --git a/arch/hexagon/include/asm/setup.h
> b/arch/hexagon/include/asm/setup.h
> > new file mode 100644
> > index 000000000000..9f2749cd4052
> > --- /dev/null
> > +++ b/arch/hexagon/include/asm/setup.h
> > @@ -0,0 +1,20 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (c) 2010-2011, The Linux Foundation. All rights reserved.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 and
> > + * only version 2 as published by the Free Software Foundation.
> > + */
> > +
> > +#ifndef _ASM_HEXAGON_SETUP_H
> > +#define _ASM_HEXAGON_SETUP_H
> > +
> > +#include <linux/init.h>
> > +#include <uapi/asm/setup.h>
> > +
> > +extern char external_cmdline_buffer;
> > +
> > +void __init setup_arch_memory(void);
> > +
> > +#endif
> > diff --git a/arch/hexagon/include/uapi/asm/setup.h
> b/arch/hexagon/include/uapi/asm/setup.h
> > index 8ce9428b1583..598f74f671f6 100644
> > --- a/arch/hexagon/include/uapi/asm/setup.h
> > +++ b/arch/hexagon/include/uapi/asm/setup.h
> > @@ -17,19 +17,9 @@
> >    * 02110-1301, USA.
> >    */
> >
> > -#ifndef _ASM_SETUP_H
> > -#define _ASM_SETUP_H
> > -
> > -#ifdef __KERNEL__
> > -#include <linux/init.h>
> > -#else
> > -#define __init
> > -#endif
> > +#ifndef _UAPI_ASM_HEXAGON_SETUP_H
> > +#define _UAPI_ASM_HEXAGON_SETUP_H
> >
> >   #include <asm-generic/setup.h>
> >
> > -extern char external_cmdline_buffer;
> > -
> > -void __init setup_arch_memory(void);
> > -
> >   #endif
> 
> Ping?
> 
>   Thomas