linux-kernel - Re: [PATCH 09/35] sysctl: Reorganize kerneldoc parameter names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6f7d5e-6f7e-ed6-a54a-2a5fd87b3d7f@inria.fr>
Date: Tue, 22 Oct 2024 13:13:25 -0700 (PDT)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Joel Granados <joel.granados@...nel.org>
cc: Luis Chamberlain <mcgrof@...nel.org>, kernel-janitors@...r.kernel.org, 
    Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org, 
    linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 09/35] sysctl: Reorganize kerneldoc parameter names



On Tue, 22 Oct 2024, Joel Granados wrote:

> On Mon, Sep 30, 2024 at 01:20:55PM +0200, Julia Lawall wrote:
> > Reorganize kerneldoc parameter names to match the parameter
> > order in the function header.
> >
> > Problems identified using Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
> >
> > ---
> >  kernel/sysctl.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > index 79e6cb1d5c48..5c9202cb8f59 100644
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write,
> >   * @write: %TRUE if this is a write to the sysctl file
> >   * @buffer: the user buffer
> >   * @lenp: the size of the user buffer
> > - * @ppos: file position
> >   * @ppos: the current position in the file
> >   *
> >   * Reads/writes up to table->maxlen/sizeof(unsigned int) integer
> >
> This looks good to me. Is it going to go into main line together with
> the other 35 or should I take this one through sysctl subsystem?

Please take it,

julia

>
> Best
>
> Signed-off-by: Joel Granados <joel.granados@...nel.com>
>
> --
>
> Joel Granados
>