Message-ID: <HzGVLZXHcn_UkULYJTtpdjJTmVWHsXHFOUSQ54FrsFFxO6-jL6ZBUR99YbWPqEpJKYVGnr3ofRAsCuKVG3eeB29-WGiPP68MfUr1thNAmjE=@proton.me>
Date: Tue, 22 Oct 2024 20:21:24 +0000
From: Piotr Zalewski <pZ010001011111@...ton.me>
To: syzbot <syzbot+47f334396d741f9cb1ce@...kaller.appspotmail.com>
Cc: kent.overstreet@...ux.dev, linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [bcachefs?] kernel BUG in bch2_journal_key_insert_take

On Monday, October 21st, 2024 at 3:07 PM, syzbot <syzbot+47f334396d741f9cb1ce@...kaller.appspotmail.com> wrote:

> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit: 15e7d45e786a Add linux-next specific files for 20241016
> git tree: linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=10a5c240580000
> kernel config: https://syzkaller.appspot.com/x/.config?x=c36416f1c54640c0
> dashboard link: https://syzkaller.appspot.com/bug?extid=47f334396d741f9cb1ce
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11044487980000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12815830580000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/cf2ad43c81cc/disk-15e7d45e.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/c85347a66a1c/vmlinux-15e7d45e.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/648cf8e59c13/bzImage-15e7d45e.xz
> mounted in repro: https://storage.googleapis.com/syzbot-assets/6ba77e840d2c/mount_0.gz
> 
> The issue was bisected to:
> 
> commit d59f4aba096298347f0e0e5402843bb8505edc2d
> Author: Kent Overstreet kent.overstreet@...ux.dev
> 
> Date: Sat Oct 12 02:53:09 2024 +0000
> 
> bcachefs: -o norecovery now bails out of recovery earlier
> 
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1580c487980000
> final oops: https://syzkaller.appspot.com/x/report.txt?x=1780c487980000
> console output: https://syzkaller.appspot.com/x/log.txt?x=1380c487980000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+47f334396d741f9cb1ce@...kaller.appspotmail.com
> Fixes: d59f4aba0962 ("bcachefs: -o norecovery now bails out of recovery earlier")
> 
> ------------[ cut here ]------------
> kernel BUG at fs/bcachefs/btree_journal_iter.c:190!
> Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
> CPU: 1 UID: 0 PID: 1169 Comm: kworker/1:2 Not tainted 6.12.0-rc3-next-20241016-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
> Workqueue: bcachefs_write_ref bch2_delete_dead_snapshots_work (bcachefs-delete-dead-snapshots/)
> RIP: 0010:bch2_journal_key_insert_take+0x180f/0x1830 fs/bcachefs/btree_journal_iter.c:190
> Code: f1 fc ff ff e8 d2 51 78 fd 90 0f 0b e8 ca 51 78 fd 90 0f 0b e8 c2 51 78 fd 90 0f 0b e8 ba 51 78 fd 90 0f 0b e8 b2 51 78 fd 90 <0f> 0b e8 4a a1 af 07 e8 a5 51 78 fd 90 0f 0b e8 9d 51 78 fd 90 0f
> 
> RSP: 0018:ffffc9000430edc0 EFLAGS: 00010293
> RAX: ffffffff841c909e RBX: 0000000000000040 RCX: ffff8880272b8000
> RDX: 0000000000000000 RSI: 0000000000000040 RDI: 0000000000000000
> RBP: ffffc9000430ef30 R08: ffffffff841c7a8e R09: 1ffff1100de80035
> R10: dffffc0000000000 R11: ffffed100de80036 R12: 0000000000000000
> R13: ffff88806f400000 R14: dffffc0000000000 R15: ffff88806f44b310
> FS: 0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000559ab32ac530 CR3: 00000000744be000 CR4: 00000000003526f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> 
> bch2_journal_key_insert+0xb3/0x130 fs/bcachefs/btree_journal_iter.c:260
> do_bch2_trans_commit_to_journal_replay+0x111/0x420 fs/bcachefs/btree_trans_commit.c:1003
> __bch2_trans_commit+0x15d9/0x9420 fs/bcachefs/btree_trans_commit.c:1039
> bch2_trans_commit fs/bcachefs/btree_update.h:184 [inline]
> bch2_delete_dead_snapshots+0x19b6/0x5ae0 fs/bcachefs/snapshot.c:1655
> bch2_delete_dead_snapshots_work+0x34/0x40 fs/bcachefs/snapshot.c:1730
> process_one_work kernel/workqueue.c:3229 [inline]
> process_scheduled_works+0xa63/0x1850 kernel/workqueue.c:3310
> worker_thread+0x870/0xd30 kernel/workqueue.c:3391
> kthread+0x2f0/0x390 kernel/kthread.c:389
> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
> </TASK>
> 
> Modules linked in:
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:bch2_journal_key_insert_take+0x180f/0x1830 fs/bcachefs/btree_journal_iter.c:190
> Cod
> 
> 
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@...glegroups.com.
> 
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> 
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
> 
> If you want syzbot to run the reproducer, reply with:
> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.
> 
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
> 
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
> 
> If you want to undo deduplication, reply with:
> #syz undup

Seems this BUG is no longer being triggered. Output with 6.12-rc5:
```
executing program
[   22.799942] loop0: detected capacity change from 0 to 32768
[   22.835885] bcachefs (loop0): starting version 1.7: mi_btree_bitmap opts=metadata_checksum=none,data_checksum=ns
[   22.837429] bcachefs (loop0): recovering from clean shutdown, journal seq 10
[   22.843604] bcachefs (loop0): check_topology... done
[   22.844050] bcachefs (loop0): accounting_read... done
[   22.849861] bcachefs (loop0): alloc_read... done
[   22.850282] bcachefs (loop0): stripes_read... done
[   22.850738] bcachefs (loop0): snapshots_read... done
[   22.851370] bcachefs (loop0): check_allocations...
[   22.852430] btree ptr not marked in member info btree allocated bitmap
[   22.852441]   u64s 11 type btree_ptr_v2 SPOS_MAX len 0 ver 0: seq ac62141f8dc7e261 written 24 min_key POS_MIN dg
[   22.854503] bcachefs (loop0): Unable to continue, halting
[   22.854977] bcachefs (loop0): bch2_gc_mark_key(): error fsck_errors_not_fixed
[   22.855673] bcachefs (loop0): bch2_gc_btree(): error fsck_errors_not_fixed
[   22.856268] bcachefs (loop0): bch2_gc_btrees(): error fsck_errors_not_fixed
[   22.857042] bcachefs (loop0): bch2_check_allocations(): error fsck_errors_not_fixed
[   22.857904] bcachefs (loop0): bch2_fs_recovery(): error fsck_errors_not_fixed
[   22.858378] bcachefs (loop0): bch2_fs_start(): error starting filesystem fsck_errors_not_fixed
[   22.858933] bcachefs (loop0): shutting down
[   22.863434] bcachefs (loop0): shutdown complete
[   23.256941] bcachefs: bch2_fs_get_tree() error: fsck_errors_not_fixed
[   23.270355] repro.elf (193) used greatest stack depth: 25792 bytes left
```

Powered by blists - more mailing lists