linux-kernel - Re: [PATCH 1/1] PCI: Move no_pci_devices() to the only driver using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZxgOzHUqFDfBDedx@google.com>
Date: Tue, 22 Oct 2024 13:45:00 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/1] PCI: Move no_pci_devices() to the only driver using
 it

Hi Bjorn, Ilpo,

On Thu, Oct 10, 2024 at 02:45:33PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 09, 2024 at 01:52:18PM +0300, Ilpo Järvinen wrote:
> > Core PCI code provides no_pci_devices() that is only used in the
> > pc110pad driver during init to detect cases when PC110 definitely cannot
> > be present. Move this legacy detection trickery/hack into the pc110pad
> > driver.
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Thanks, this is indeed a gross hack, and I'd be glad to eradicate it
> from PCI.

I would much rather remove pc110_pad altogether. If I can get a
"Reviewed-by" on [1] that would be great.

[1] https://lore.kernel.org/all/20240808172733.1194442-4-dmitry.torokhov@gmail.com/

Thanks.

-- 
Dmitry