linux-kernel - [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241022213450.15041-4-gourry@gourry.net>
Date: Tue, 22 Oct 2024 17:34:50 -0400
From: Gregory Price <gourry@...rry.net>
To: x86@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org,
	linux-mm@...ck.org
Cc: linux-cxl@...ck.org,
	Jonathan.Cameron@...wei.com,
	dan.j.williams@...el.com,
	rrichter@....com,
	Terry.Bowman@....com,
	dave.jiang@...el.com,
	ira.weiny@...el.com,
	alison.schofield@...el.com,
	gourry@...rry.net,
	dave.hansen@...ux.intel.com,
	luto@...nel.org,
	peterz@...radead.org,
	tglx@...utronix.de,
	mingo@...hat.com,
	bp@...en8.de,
	hpa@...or.com,
	rafael@...nel.org,
	lenb@...nel.org,
	david@...hat.com,
	osalvador@...e.de,
	gregkh@...uxfoundation.org,
	akpm@...ux-foundation.org,
	rppt@...nel.org
Subject: [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment

Capacity is stranded when CFMWS regions are not aligned to block size.
On x86, block size increases with capacity (2G blocks @ 64G capacity).

Use CFMWS base/size to report memory block size alignment advice.

After the alignment, the acpi code begins populating numa nodes with
memblocks, so probe the value just prior to lock it in.  All future
callers should be providing advice prior to this point.

Suggested-by: Dan Williams <dan.j.williams@...el.com>
Signed-off-by: Gregory Price <gourry@...rry.net>
---
 drivers/acpi/numa/srat.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
index 44f91f2c6c5d..35e6f7c17f60 100644
--- a/drivers/acpi/numa/srat.c
+++ b/drivers/acpi/numa/srat.c
@@ -14,6 +14,7 @@
 #include <linux/errno.h>
 #include <linux/acpi.h>
 #include <linux/memblock.h>
+#include <linux/memory.h>
 #include <linux/numa.h>
 #include <linux/nodemask.h>
 #include <linux/topology.h>
@@ -333,6 +334,29 @@ acpi_parse_memory_affinity(union acpi_subtable_headers *header,
 	return 0;
 }
 
+/* Advise memblock on maximum block size to avoid stranded capacity. */
+static int __init acpi_align_cfmws(union acpi_subtable_headers *header,
+				   void *arg, const unsigned long table_end)
+{
+	struct acpi_cedt_cfmws *cfmws = (struct acpi_cedt_cfmws *)header;
+	u64 start = cfmws->base_hpa;
+	u64 size = cfmws->window_size;
+	unsigned long bz;
+
+	for (bz = SZ_64T; bz >= SZ_256M; bz >>= 1) {
+		if (IS_ALIGNED(start, bz) && IS_ALIGNED(size, bz))
+			break;
+	}
+
+	if (bz >= SZ_256M) {
+		if (memory_block_advise_max_size(bz) < 0)
+			pr_warn("CFMWS: memblock size advise failed\n");
+	} else
+		pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n");
+
+	return 0;
+}
+
 static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
 				   void *arg, const unsigned long table_end)
 {
@@ -545,6 +569,15 @@ int __init acpi_numa_init(void)
 	 * Initialize a fake_pxm as the first available PXM to emulate.
 	 */
 
+	/* Align memblock size to CFMW regions if possible */
+	acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_align_cfmws, NULL);
+
+	/*
+	 * Nodes start populating with blocks after this, so probe the max
+	 * block size to prevent it from changing in the future.
+	 */
+	memory_block_probe_max_size();
+
 	/* fake_pxm is the next unused PXM value after SRAT parsing */
 	for (i = 0, fake_pxm = -1; i < MAX_NUMNODES; i++) {
 		if (node_to_pxm_map[i] > fake_pxm)
-- 
2.43.0