linux-kernel - Re: [PATCH] block: remove redundant explicit memory barrier from rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172963590674.1032314.6365851966628094463.b4-ty@kernel.dk>
Date: Tue, 22 Oct 2024 16:25:06 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Muchun Song <muchun.song@...ux.dev>
Cc: josef@...icpanda.com, oleg@...hat.com, linux-block@...r.kernel.org, 
 linux-kernel@...r.kernel.org, muchun.song@...ux.dev
Subject: Re: [PATCH] block: remove redundant explicit memory barrier from
 rq_qos waiter and waker


On Mon, 21 Oct 2024 16:52:51 +0800, Muchun Song wrote:
> The memory barriers in list_del_init_careful() and list_empty_careful()
> in pairs already handle the proper ordering between data.got_token
> and data.wq.entry. So remove the redundant explicit barriers. And also
> change a "break" statement to "return" to avoid redundant calling of
> finish_wait().
> 
> 
> [...]

Applied, thanks!

[1/1] block: remove redundant explicit memory barrier from rq_qos waiter and waker
      commit: 904ebd2527c507752f5ddb358f887d2e0dab96a0

Best regards,
-- 
Jens Axboe