linux-kernel - Re: [PATCH v5 7/8] arm64: dts: qcom: Update sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <amnapm4ig6ivhmle4tgywi2n7ah54cha3gpl5sowvf2rqvhg6s@7xg2afpus4ej>
Date: Tue, 22 Oct 2024 17:31:32 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Taniya Das <quic_tdas@...cinc.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, quic_imrashai@...cinc.com, quic_jkona@...cinc.com, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 7/8] arm64: dts: qcom: Update sleep_clk frequency to
 32000 on SA8775P

On Fri, Oct 11, 2024 at 12:28:37AM GMT, Taniya Das wrote:
> The HW supported sleep_clk frequency on SA8775P is 32000, hence
> update the sleep_clk frequency with the correct value on SA8775P.
> 
> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>

It's generally expected that bug fixes are sent first in patch series,
but perhaps it's fine as this is the first DT-patch in the series.

That said, the only relationship between this patch and the rest of this
series is...you. There's no reason for sending this together with the
multimedia clock drivers.


Further, the patch subject doesn't match the expected format. It's too
long (not a summary) and it doesn't have the expected subject prefix for
changes to this file.

Please correct this.

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> index 0c1b21def4b62cc65a693552983ec0bc7eec697d..adb71aeff339b564eb3acc42a38bba2f03507508 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> @@ -517,7 +517,7 @@ &serdes1 {
>  };
>  
>  &sleep_clk {
> -	clock-frequency = <32764>;
> +	clock-frequency = <32000>;
>  };
>  
>  &spi16 {
> 
> -- 
> 2.45.2
>