linux-kernel - Re: [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpHpyCMWSpf_+JZgVNoQ5UMHdo9b258aathkou0dgGPung@mail.gmail.com>
Date: Tue, 22 Oct 2024 16:04:31 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: Sourav Panda <souravpanda@...gle.com>, akpm@...ux-foundation.org, yuzhao@...gle.com, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, weixugc@...gle.com
Subject: Re: [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub

On Tue, Oct 22, 2024 at 2:03 PM Pasha Tatashin
<pasha.tatashin@...een.com> wrote:
>
> On Tue, Oct 22, 2024 at 4:56 PM Sourav Panda <souravpanda@...gle.com> wrote:
> >
> > alloc_tag_sub() takes bytes as opposed to number of pages as argument.
> >
> > Currently pgalloc_tag_copy() passes the number of pages. This fix passes
> > the current unit, which is the number of bytes allocated.
> >
> > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()")
> > Signed-off-by: Sourav Panda <souravpanda@...gle.com>
>
> Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>

Oops... Thanks for the fix!

Acked-by: Suren Baghdasaryan <surenb@...gle.com>

>
> Thanks,
> Pasha
>
> > ---
> >  include/linux/mm.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index ecf63d2b0582..2890001c8b97 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *new, struct folio *old)
> >         /* Clear the old ref to the original allocation tag. */
> >         clear_page_tag_ref(&old->page);
> >         /* Decrement the counters of the tag on get_new_folio. */
> > -       alloc_tag_sub(ref, folio_nr_pages(new));
> > +       alloc_tag_sub(ref, folio_size(new));
> >
> >         __alloc_tag_ref_set(ref, tag);
> >
> > --
> > 2.47.0.105.g07ac214952-goog
> >