linux-kernel - Re: [PATCH v4 1/2] virt: pvmemcontrol: control guest physical memory properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024102220-creed-darkening-aac0@gregkh>
Date: Tue, 22 Oct 2024 07:18:44 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Yuanchu Xie <yuanchu@...gle.com>
Cc: Wei Liu <liuwe@...rosoft.com>, Rob Bradford <rbradford@...osinc.com>,
	Theodore Ts'o <tytso@....edu>,
	Pasha Tatashin <pasha.tatashin@...een.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	virtualization@...ts.linux.dev, dev@...ts.cloudhypervisor.org
Subject: Re: [PATCH v4 1/2] virt: pvmemcontrol: control guest physical memory
 properties

On Mon, Oct 21, 2024 at 01:48:48PM -0700, Yuanchu Xie wrote:
> +static DEFINE_RWLOCK(pvmemcontrol_lock);

What does this lock control?

> +static struct pvmemcontrol *pvmemcontrol __read_mostly;

Having a single static device should not be needed, please tie this
properly to the pci device that the driver core gives you.  With this
design, you have limited yourself to a fixed number of devices in the
system at once (i.e. 1).  This isn't the 1990's anymore, drivers should
be able to handle any number of devices at once.

thanks,

greg k-h