linux-kernel - Re: [PATCH v3] PCI: imx6: Add suspend/resume support for i.MX6QDL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410221309.BXeJNrxw-lkp@intel.com>
Date: Tue, 22 Oct 2024 13:34:51 +0800
From: kernel test robot <lkp@...el.com>
To: Stefan Eichenberger <eichest@...il.com>, hongxing.zhu@....com,
	l.stach@...gutronix.de, lpieralisi@...nel.org, kw@...ux.com,
	manivannan.sadhasivam@...aro.org, robh@...nel.org,
	bhelgaas@...gle.com, shawnguo@...nel.org, s.hauer@...gutronix.de,
	kernel@...gutronix.de, festevam@...il.com,
	francesco.dolcini@...adex.com, Frank.li@....com
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Stefan Eichenberger <stefan.eichenberger@...adex.com>
Subject: Re: [PATCH v3] PCI: imx6: Add suspend/resume support for i.MX6QDL

Hi Stefan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.12-rc4 next-20241021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stefan-Eichenberger/PCI-imx6-Add-suspend-resume-support-for-i-MX6QDL/20241021-205155
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20241021124922.5361-1-eichest%40gmail.com
patch subject: [PATCH v3] PCI: imx6: Add suspend/resume support for i.MX6QDL
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241022/202410221309.BXeJNrxw-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241022/202410221309.BXeJNrxw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410221309.BXeJNrxw-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pci-imx6.c:86: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Because of ERR005723 (PCIe does not support L2 power down) we need to


vim +86 drivers/pci/controller/dwc/pci-imx6.c

    75	
    76	#define IMX_PCIE_FLAG_IMX_PHY			BIT(0)
    77	#define IMX_PCIE_FLAG_IMX_SPEED_CHANGE		BIT(1)
    78	#define IMX_PCIE_FLAG_SUPPORTS_SUSPEND		BIT(2)
    79	#define IMX_PCIE_FLAG_HAS_PHYDRV		BIT(3)
    80	#define IMX_PCIE_FLAG_HAS_APP_RESET		BIT(4)
    81	#define IMX_PCIE_FLAG_HAS_PHY_RESET		BIT(5)
    82	#define IMX_PCIE_FLAG_HAS_SERDES		BIT(6)
    83	#define IMX_PCIE_FLAG_SUPPORT_64BIT		BIT(7)
    84	#define IMX_PCIE_FLAG_CPU_ADDR_FIXUP		BIT(8)
    85	/**
  > 86	 * Because of ERR005723 (PCIe does not support L2 power down) we need to
    87	 * workaround suspend resume on some devices which are affected by this errata.
    88	 */
    89	#define IMX_PCIE_FLAG_BROKEN_SUSPEND		BIT(9)
    90	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki