[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zxc/1zw/LGd3PKl5@BLRRASHENOY1.amd.com>
Date: Tue, 22 Oct 2024 11:31:59 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@....com>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Borislav Petkov <bp@...en8.de>, Hans de Goede <hdegoede@...hat.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
x86@...nel.org, Perry Yuan <perry.yuan@....com>,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-pm@...r.kernel.org, platform-driver-x86@...r.kernel.org,
Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v4 09/13] platform/x86: hfi: add power management callback
On Mon, Oct 21, 2024 at 01:02:48PM -0500, Mario Limonciello wrote:
> From: Perry Yuan <Perry.Yuan@....com>
>
> Introduces power management callbacks for the `amd_hfi` driver.
> Specifically, the `suspend` and `resume` callbacks have been added
> to handle the necessary operations during system low power states
> and wake-up.
>
> Signed-off-by: Perry Yuan <Perry.Yuan@....com>
> Co-developed-by: Mario Limonciello <mario.limonciello@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@....com>
> ---
> v3->v4:
> * Use for_each_online_cpu (Gautham)
> v2->v3:
> * Whitespace (Ilpo)
> ---
> drivers/platform/x86/amd/hfi/hfi.c | 33 ++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
> index 70ddde37f283f..c8fe03d0c9ccd 100644
> --- a/drivers/platform/x86/amd/hfi/hfi.c
> +++ b/drivers/platform/x86/amd/hfi/hfi.c
> @@ -388,6 +388,38 @@ static int amd_hfi_metadata_parser(struct platform_device *pdev,
> return ret;
> }
>
> +static int amd_hfi_pm_resume(struct device *dev)
> +{
> + int ret, cpu;
> +
> + for_each_online_cpu(cpu) {
> + ret = amd_hfi_set_state(cpu, true);
> + if (ret < 0) {
> + dev_err(dev, "failed to enable workload class config: %d\n", ret);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> +static int amd_hfi_pm_suspend(struct device *dev)
> +{
> + int ret, cpu;
> +
> + for_each_online_cpu(cpu) {
> + ret = amd_hfi_set_state(cpu, false);
> + if (ret < 0) {
> + dev_err(dev, "failed to disable workload class config: %d\n", ret);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(amd_hfi_pm_ops, amd_hfi_pm_suspend, amd_hfi_pm_resume);
> +
> static const struct acpi_device_id amd_hfi_platform_match[] = {
> { "AMDI0104", 0},
> { }
> @@ -434,6 +466,7 @@ static struct platform_driver amd_hfi_driver = {
> .driver = {
> .name = AMD_HFI_DRIVER,
> .owner = THIS_MODULE,
> + .pm = &amd_hfi_pm_ops,
> .acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
> },
> .probe = amd_hfi_probe,
> --
> 2.43.0
>
Powered by blists - more mailing lists