linux-kernel - RE: [PATCH 2/4] scsi: ufs: core: Use reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL0PR04MB6564943551782240CAD17557FC4C2@BL0PR04MB6564.namprd04.prod.outlook.com>
Date: Tue, 22 Oct 2024 06:02:41 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/4] scsi: ufs: core: Use reg_lock to protect UTMRLCLR

> 
> On 10/21/24 5:03 AM, Avri Altman wrote:
> >       if (!test_bit(tag, &hba->outstanding_tasks))
> >               goto out;
> >
> > -     spin_lock_irqsave(hba->host->host_lock, flags);
> > +     spin_lock_irqsave(&hba->reg_lock, flags);
> >       ufshcd_utmrl_clear(hba, tag);
> > -     spin_unlock_irqrestore(hba->host->host_lock, flags);
> > +     spin_unlock_irqrestore(&hba->reg_lock, flags);
> >
> >       /* poll for max. 1 sec to clear door bell register by h/w */
> >       err = ufshcd_wait_for_register(hba,
> 
> Hi Avri,
> 
> ufshcd_utmrl_clear() performs a single write so I assume that calls of that
> function do not have to be serialized?
Done.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.