linux-kernel - Re: [PATCH] btrfs: Fix passing 0 to ERR_PTR in btrfs_search_dir_index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afa71ba0-8029-44b1-90fe-c8e45bb02657@wdc.com>
Date: Tue, 22 Oct 2024 07:16:17 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Yue Haibing <yuehaibing@...wei.com>, "clm@...com" <clm@...com>,
	"josef@...icpanda.com" <josef@...icpanda.com>, "dsterba@...e.com"
	<dsterba@...e.com>, "mpdesouza@...e.com" <mpdesouza@...e.com>,
	"gniebler@...e.com" <gniebler@...e.com>
CC: "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] btrfs: Fix passing 0 to ERR_PTR in
 btrfs_search_dir_index_item()

On 22.10.24 08:53, Yue Haibing wrote:
>> and then set it to ENOENT if it is NULL. So it should be
>>
>> if (ret >= 0)
>> 	ret = -ENOENT;
>> return ERR_PTR(-ENOENT);
> 
> Here should be
> return ERR_PTR(ret);

Yep of cause.