linux-kernel - Re: [PATCH] usbip: tools: update return status when failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxdbKiwZ1fz4kAZw@Sun>
Date: Tue, 22 Oct 2024 15:58:34 +0800
From: Hongren Zheng <i@...ithal.me>
To: Zongmin Zhou <min_halo@....com>
Cc: valentina.manea.m@...il.com, shuah@...nel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Zongmin Zhou <zhouzongmin@...inos.cn>
Subject: Re: [PATCH] usbip: tools: update return status when failed

On Tue, Oct 22, 2024 at 02:48:56PM +0800, Zongmin Zhou wrote:
> From: Zongmin Zhou <zhouzongmin@...inos.cn>
> 
> Have to set "ret" before return when found a invalid port.
> 
> Signed-off-by: Zongmin Zhou <zhouzongmin@...inos.cn>

Reviewed-by: Hongren Zheng <i@...ithal.me>

> ---
>  tools/usb/usbip/src/usbip_detach.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c
> index b29101986b5a..6b78d4a81e95 100644
> --- a/tools/usb/usbip/src/usbip_detach.c
> +++ b/tools/usb/usbip/src/usbip_detach.c
> @@ -68,6 +68,7 @@ static int detach_port(char *port)
>  	}
>  
>  	if (!found) {
> +		ret = -1;
>  		err("Invalid port %s > maxports %d",
>  			port, vhci_driver->nports);
>  		goto call_driver_close;
> -- 
> 2.34.1
>