linux-kernel - Re: [PATCH] ARM: dts: imx7s: change i2c compatible string for applying errata ERR007805

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM0PR0402MB3937B89BD8A42DDFAD2F703CE84C2@AM0PR0402MB3937.eurprd04.prod.outlook.com>
Date: Tue, 22 Oct 2024 08:45:15 +0000
From: Carlos Song <carlos.song@....com>
To: Francesco Dolcini <francesco@...cini.it>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, Frank Li <frank.li@....com>, Bough
 Chen <haibo.chen@....com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: imx7s: change i2c compatible string for
 applying errata ERR007805



> -----Original Message-----
> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Tuesday, October 22, 2024 3:40 PM
> To: Carlos Song <carlos.song@....com>
> Cc: Francesco Dolcini <francesco@...cini.it>; robh@...nel.org;
> krzk+dt@...nel.org; conor+dt@...nel.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> Frank Li <frank.li@....com>; Bough Chen <haibo.chen@....com>;
> devicetree@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH] ARM: dts: imx7s: change i2c compatible string for
> applying errata ERR007805
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> On Mon, Oct 21, 2024 at 10:07:23AM +0000, Carlos Song wrote:
> > > From: Francesco Dolcini <francesco@...cini.it>
> > >
> > > On Mon, Oct 21, 2024 at 11:11:48AM +0800, carlos.song@....com wrote:
> > > > From: Carlos Song <carlos.song@....com>
> > > >
> > > > Compatible string "fsl,imx7d-i2c" is not exited at i2c-imx driver
> > > > compatible string table, at the result, "fsl,imx21-i2c" will be
> > > > matched, but it will cause errata ERR007805 not be applied in fact.
> > > >
> > > > Replace "fsl,imx7d-i2c" by "fsl,imx7s-i2c" compatible string in
> > > > dts file for appling the errata ERR007805.
> > >
> > > Did you considered changing the driver instead? If I understand this
> > > correctly it would be a better solution.
> >
> > This errata fix patch has been applied on i2c-imx.c driver: 39c025721d70 i2c:
> > imx: Implement errata ERR007805 or e7805 bus frequency limit
> >
> > The patch commit log says: this errata is found on all MX7{S,D},
> > MX6{UL{,L,Z},S{,LL,X},S,D,DL,Q,DP,QP} and MX8M{M,N,P,Q}.  So imx7d and
> > imx7s both needs this errata fix. "fsl,imx7s-i2c" was added into
> > compatible string table in the i2c-imx patch, this is the patch diff
> > snap.  So when "fsl,imx7s-i2c" is matched, the arrata fix will be applied.
> 
> It is clear what you did. What I wrote is that IMO it's not the correct solution.
> 
> Kernel and the FDT can be updated indipendently, with the FDT being part of the
> firmware, and you should not expect people to update the FDT to fix an errata
> that is implemented in the driver.
> 
> My suggestion is that the errata should be applied in the driver to both
> compatibles, and such a fix should be backported to stable kernel.
> 
> Francesco

Hi, Francesco

Thanks! I get it. I will send V2 patch in i2c-imx.c driver to add one compatible string for imx7d
to fix this errata.

Carlos