linux-kernel - Re: [PATCH net-next v3 05/10] net: ip: make ip_route_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3atdr5Rm1CU8_AU1XaczraYN7ihTJWQiqxaStmD4iETog@mail.gmail.com>
Date: Tue, 22 Oct 2024 16:50:36 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	dsahern@...nel.org, pablo@...filter.org, kadlec@...filter.org, 
	roopa@...dia.com, razor@...ckwall.org, gnault@...hat.com, 
	bigeasy@...utronix.de, idosch@...dia.com, ast@...nel.org, 
	dongml2@...natelecom.cn, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
	bridge@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v3 05/10] net: ip: make ip_route_input_slow()
 return drop reasons

On Mon, Oct 21, 2024 at 6:52 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 10/15/24 16:07, Menglong Dong wrote:
> > @@ -2316,19 +2327,25 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
> >               err = -EHOSTUNREACH;
> >               goto no_route;
> >       }
> > -     if (res->type != RTN_UNICAST)
> > +     if (res->type != RTN_UNICAST) {
> > +             reason = SKB_DROP_REASON_IP_INVALID_DEST;
> >               goto martian_destination;
> > +     }
> >
> >  make_route:
> >       err = ip_mkroute_input(skb, res, in_dev, daddr, saddr, dscp, flkeys);
> > -out: return err;
> > +     if (!err)
> > +             reason = SKB_NOT_DROPPED_YET;
> > +
> > +out: return reason;
>
> Since you are touching this line, please rewrite the code with a more
> natural indentation:
>
> out:
>         return reason;
>

Okay!

> Thanks,
>
> Paolo
>