[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZxdtUm_uoFvvKtVl@apocalypse>
Date: Tue, 22 Oct 2024 11:16:02 +0200
From: Andrea della Porta <andrea.porta@...e.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Andrea della Porta <andrea.porta@...e.com>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Linus Walleij <linus.walleij@...aro.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
Derek Kiernan <derek.kiernan@....com>,
Dragan Cvetic <dragan.cvetic@....com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Saravana Kannan <saravanak@...gle.com>, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-pci@...r.kernel.org, linux-gpio@...r.kernel.org,
Masahiro Yamada <masahiroy@...nel.org>,
Stefan Wahren <wahrenst@....net>,
Herve Codina <herve.codina@...tlin.com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2 03/14] dt-bindings: pci: Add common schema for devices
accessible through PCI BARs
Hi Krzysztof,
On 08:24 Tue 08 Oct , Krzysztof Kozlowski wrote:
> On Mon, Oct 07, 2024 at 02:39:46PM +0200, Andrea della Porta wrote:
> > Common YAML schema for devices that exports internal peripherals through
> > PCI BARs. The BARs are exposed as simple-buses through which the
> > peripherals can be accessed.
> >
> > This is not intended to be used as a standalone binding, but should be
> > included by device specific bindings.
>
> It still has to be tested before posting... Mailing list is not a
> testing service. My and Rob's machines are not a testing service.
Sorry about that, I must have missed that file when rechecking all the schemas
after rebasing on 6.12-rc1.
>
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
> > ---
> > .../devicetree/bindings/pci/pci-ep-bus.yaml | 69 +++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 70 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pci/pci-ep-bus.yaml b/Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
> > new file mode 100644
> > index 000000000000..9d7a784b866a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pci/pci-ep-bus.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Common properties for PCI MFD endpoints with peripherals addressable from BARs.
>
> Drop full stop and capitalize it.
Ack.
>
> > +
> > +maintainers:
> > + - Andrea della Porta <andrea.porta@...e.com>
> > +
> > +description:
> > + Define a generic node representing a PCI endpoint which contains several sub-
> > + peripherals. The peripherals can be accessed through one or more BARs.
> > + This common schema is intended to be referenced from device tree bindings, and
> > + does not represent a device tree binding by itself.
> > +
> > +properties:
> > + "#address-cells":
>
> Use consistent quotes, either ' or ".
Ack.
Many thanks,
Andrea
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists