linux-kernel - Re: [PATCH v3] drm/mediatek: Fix color format MACROs in OVL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4aca41996a991cb64f7a6f2e94c3c1985164890.camel@mediatek.com>
Date: Tue, 22 Oct 2024 09:37:36 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "airlied@...il.com"
	<airlied@...il.com>, "yuanhsinte@...omium.org" <yuanhsinte@...omium.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "simona@...ll.ch"
	<simona@...ll.ch>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "dianders@...omium.org"
	<dianders@...omium.org>
Subject: Re: [PATCH v3] drm/mediatek: Fix color format MACROs in OVL

Hi, Hsin-te:

On Wed, 2024-10-16 at 14:17 +0000, Hsin-Te Yuan wrote:
>  	 
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>  In commit 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in
> OVL"), some new color formats are defined in the MACROs to make the
> switch statement more concise. That commit was intended to be a no-op
> cleanup. However, there are typos in these formats MACROs, which cause
> the return value to be incorrect. Fix the typos to ensure the return
> value remains unchanged.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL")
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@...omium.org>
> ---
> Changes in v3:
> - Add missing Reviewed-by tag
> - Link to v2: https://lore.kernel.org/r/20241016-color-v2-1-46db5c78a54f@chromium.org
> 
> Changes in v2:
> - Clarify that the commit get fixed was intended to be a no-op cleanup
> - Fix the typo in tag
> - Link to v1: https://lore.kernel.org/r/20241015-color-v1-1-35b01fa0a826@chromium.org
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 89b439dcf3a6af9f5799487fdc0f128a9b5cbe4a..1632ac5c23d87e1cdc41013a9cf7864728dcb63b 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -65,8 +65,8 @@
>  #define OVL_CON_CLRFMT_RGB(1 << 12)
>  #define OVL_CON_CLRFMT_ARGB8888(2 << 12)
>  #define OVL_CON_CLRFMT_RGBA8888(3 << 12)
> -#define OVL_CON_CLRFMT_ABGR8888(OVL_CON_CLRFMT_RGBA8888 | OVL_CON_BYTE_SWAP)
> -#define OVL_CON_CLRFMT_BGRA8888(OVL_CON_CLRFMT_ARGB8888 | OVL_CON_BYTE_SWAP)
> +#define OVL_CON_CLRFMT_ABGR8888(OVL_CON_CLRFMT_ARGB8888 | OVL_CON_BYTE_SWAP)
> +#define OVL_CON_CLRFMT_BGRA8888(OVL_CON_CLRFMT_RGBA8888 | OVL_CON_BYTE_SWAP)
>  #define OVL_CON_CLRFMT_UYVY(4 << 12)
>  #define OVL_CON_CLRFMT_YUYV(5 << 12)
>  #define OVL_CON_MTX_YUV_TO_RGB(6 << 16)
> 
> ---
> base-commit: 75b607fab38d149f232f01eae5e6392b394dd659
> change-id: 20241015-color-e205e75b64aa
> 
> Best regards,
> -- 
> Hsin-Te Yuan <yuanhsinte@...omium.org>
>