linux-kernel - Re: [PATCH v3] usb: core: adds support for PM control of specific USB dev skip suspend.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024102239-stainable-favored-558b@gregkh>
Date: Tue, 22 Oct 2024 11:39:12 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: huanglei814 <huanglei814@....com>
Cc: mathias.nyman@...el.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, huanglei <huanglei@...inos.cn>
Subject: Re: [PATCH v3] usb: core: adds support for PM control of specific
 USB dev skip suspend.

On Tue, Oct 22, 2024 at 05:09:05PM +0800, huanglei814 wrote:
> From: huanglei <huanglei@...inos.cn>
> 
> All USB devices are brought into suspend power state after system suspend.
> It is desirable for some specific manufacturers buses to keep their devices
> in normal state even after system suspend.
> 
> v2: Change to bool type for skip_suspend.
> v3: Rebase and update commit message.

As per the documentation, this needs to go below the --- line.  Also,
you changed more than just the bool type in v2 :(

Please fix up and do a v4 after waiting a while for others to review
this.

thanks,

greg k-h