linux-kernel - Re: [PATCHv8 net-next 0/5] ibm: emac: more cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b807d16-2025-4c2c-9511-573e63be1d59@amd.com>
Date: Mon, 21 Oct 2024 17:50:32 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Rosen Penev <rosenp@...il.com>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv8 net-next 0/5] ibm: emac: more cleanups

On 10/21/2024 5:22 PM, Rosen Penev wrote:
> 
> Tested on Cisco MX60W.
> 
> v2: fixed build errors. Also added extra commits to clean the driver up
> further.
> v3: Added tested message. Removed bad alloc_netdev_dummy commit.
> v4: removed modules changes from patchset. Added fix for if MAC not
> found.
> v5: added of_find_matching_node commit.
> v6: resend after net-next merge.
> v7: removed of_find_matching_node commit. Adjusted mutex_init patch.
> v8: removed patch removing custom init/exit. Needs more work.
> 
> Rosen Penev (5):
>    net: ibm: emac: use netif_receive_skb_list
>    net: ibm: emac: use devm_platform_ioremap_resource
>    net: ibm: emac: use platform_get_irq
>    net: ibm: emac: use devm for mutex_init
>    net: ibm: emac: generate random MAC if not found
> 
>   drivers/net/ethernet/ibm/emac/core.c | 42 +++++++++++++++-------------
>   1 file changed, 22 insertions(+), 20 deletions(-)
> 
> --
> 2.47.0
> 

These look reasonable - thanks.

Reviewed-by: Shannon Nelson <shannon.nelson@....com>