linux-kernel - Re: [PATCH] media: vb2: Fix comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAFQd5Dkrr-U5jgZb5vN8zw0-2cYBV+y2podSQO5zuEq761CBw@mail.gmail.com>
Date: Tue, 22 Oct 2024 19:16:32 +0900
From: Tomasz Figa <tfiga@...omium.org>
To: Ricardo Ribalda <ribalda@...omium.org>, Hans Verkuil <hverkuil@...all.nl>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, 
	Pawel Osciak <p.osciak@...sung.com>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: vb2: Fix comment

On Tue, Oct 22, 2024 at 4:56 PM Ricardo Ribalda <ribalda@...omium.org> wrote:
>
> If V4L2_TYPE_IS_OUTPUT() the information has been initially provided by
> the user, not by the driver.
>
> Fixes: e23ccc0ad925 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework")
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> index 293f3d5f1c4e..9201d854dbcc 100644
> --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
> +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> @@ -231,7 +231,7 @@ static int vb2_fill_vb2_v4l2_buffer(struct vb2_buffer *vb, struct v4l2_buffer *b
>                         break;
>                 }
>
> -               /* Fill in driver-provided information for OUTPUT types */
> +               /* Fill in user-provided information for OUTPUT types */
>                 if (V4L2_TYPE_IS_OUTPUT(b->type)) {
>                         /*
>                          * Will have to go up to b->length when API starts
>
> ---
> base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
> change-id: 20241022-vb2-comment-f5e93ca193d1
>
> Best regards,
> --
> Ricardo Ribalda <ribalda@...omium.org>
>

That's correct. It's not really a fix, but a clean-up, though, so the
Fixes: tag may be confusing. I'll leave it to Hans and Mauro, though.

Acked-by: Tomasz Figa <tfiga@...omium.org>

Best,
Tomasz