linux-kernel - perf_event_detach_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241022111638.GC16066@noisy.programming.kicks-ass.net>
Date: Tue, 22 Oct 2024 13:16:38 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: andrii@...nel.org, yhs@...com, jolsa@...nel.org,
	linux-kernel@...r.kernel.org
Cc: daniel@...earbox.net, sean@...s.org
Subject: perf_event_detach_bpf_prog() broken?

Hi guys,

Per commit 170a7e3ea070 ("bpf: bpf_prog_array_copy() should return
-ENOENT if exclude_prog not found") perf_event_detach_bpf_prog() can now
return without doing bpf_prog_put() and leaving event->prog set.

This is very 'unexpected' behaviour.

I'm not sure what's sane from the BPF side of things here, but leaving
event->prog set is really rather unexpected.

Help?