linux-kernel - RE: [PATCH] iommu: Distinguish between sw-msi and msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY0PR06MB49849D564F3FFE2E1957F4AF854C2@TY0PR06MB4984.apcprd06.prod.outlook.com>
Date: Tue, 22 Oct 2024 12:02:02 +0000
From: Angus Chen <angus.chen@...uarmicro.com>
To: Robin Murphy <robin.murphy@....com>, "joro@...tes.org" <joro@...tes.org>,
	"will@...nel.org" <will@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>
Subject: RE: [PATCH] iommu: Distinguish between sw-msi and msi

Hi robin。

> -----Original Message-----
> From: Robin Murphy <robin.murphy@....com>
> Sent: Monday, October 21, 2024 7:59 PM
> To: Angus Chen <angus.chen@...uarmicro.com>; joro@...tes.org;
> will@...nel.org
> Cc: linux-kernel@...r.kernel.org; iommu@...ts.linux.dev
> Subject: Re: [PATCH] iommu: Distinguish between sw-msi and msi
> 
> On 2024-10-21 12:34 pm, Angus Chen wrote:
> > iommu_group_resv_type_string use the same string of IOMMU_RESV_MSI
> > and IOMMU_RESV_SW_MSI, Make a distinction for these.
> 
> Why? What in userspace needs to know the exact details of how the kernel
> and the underlying hardware are routing MSIs?
We use smmu-v3 for a dpu design，and we set a private region to handle msi region like x86.
We set some private iommu register to control this.
If some customer want to use their os like openouler, we use sw-msi mode.
If some customer want to use our customize os ,we will set msi private.
Some customer use openouler and we private smmu-v3 module at the same time,

So I want to use reserve-type to distinguish between sw-msi and msi.
> 
> Thanks,
> Robin.
> 
> > Signed-off-by: Angus Chen <angus.chen@...uarmicro.com>
> > ---
> >   drivers/iommu/iommu.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 83c8e617a2c5..8a2bbb5c4a91 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -84,7 +84,7 @@ static const char * const
> iommu_group_resv_type_string[] = {
> >   	[IOMMU_RESV_DIRECT_RELAXABLE]		= "direct-relaxable",
> >   	[IOMMU_RESV_RESERVED]			= "reserved",
> >   	[IOMMU_RESV_MSI]			= "msi",
> > -	[IOMMU_RESV_SW_MSI]			= "msi",
> > +	[IOMMU_RESV_SW_MSI]			= "sw-msi",
> >   };
> >
> >   #define IOMMU_CMD_LINE_DMA_API		BIT(0)