linux-kernel - Re: [PATCH] platform/x86: eeepc-laptop: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad76d2f6-7045-4c82-b8be-0214b312b8ce@redhat.com>
Date: Tue, 22 Oct 2024 14:41:18 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: chen zhang <chenzhang@...inos.cn>, ilpo.jarvinen@...ux.intel.com,
 corentin.chary@...il.com, luke@...nes.dev
Cc: linux-kernel@...r.kernel.org, chenzhang_0901@....com,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: eeepc-laptop: use sysfs_emit() instead of
 sprintf()

Hi,

On 18-Oct-24 11:55 AM, chen zhang wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: chen zhang <chenzhang@...inos.cn>
> ---
>  drivers/platform/x86/eeepc-laptop.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 03319a80e114..ba36b7bf6dc4 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c

You need to add a:

#include <linux/sysfs.h>

when using sysfs_emit() .

Please send a v2 with this fixed and please don't forget to Cc:

platform-driver-x86@...r.kernel.org

for the v2.

Regards,

Hans





> @@ -285,7 +285,7 @@ static ssize_t show_sys_acpi(struct device *dev, int cm, char *buf)
>  
>  	if (value < 0)
>  		return -EIO;
> -	return sprintf(buf, "%d\n", value);
> +	return sysfs_emit(buf, "%d\n", value);
>  }
>  
>  #define EEEPC_ACPI_SHOW_FUNC(_name, _cm)				\
> @@ -361,7 +361,7 @@ static ssize_t cpufv_show(struct device *dev,
>  
>  	if (get_cpufv(eeepc, &c))
>  		return -ENODEV;
> -	return sprintf(buf, "%#x\n", (c.num << 8) | c.cur);
> +	return sysfs_emit(buf, "%#x\n", (c.num << 8) | c.cur);
>  }
>  
>  static ssize_t cpufv_store(struct device *dev,
> @@ -393,7 +393,7 @@ static ssize_t cpufv_disabled_show(struct device *dev,
>  {
>  	struct eeepc_laptop *eeepc = dev_get_drvdata(dev);
>  
> -	return sprintf(buf, "%d\n", eeepc->cpufv_disabled);
> +	return sysfs_emit(buf, "%d\n", eeepc->cpufv_disabled);
>  }
>  
>  static ssize_t cpufv_disabled_store(struct device *dev,
> @@ -1025,7 +1025,7 @@ static ssize_t store_sys_hwmon(void (*set)(int), const char *buf, size_t count)
>  
>  static ssize_t show_sys_hwmon(int (*get)(void), char *buf)
>  {
> -	return sprintf(buf, "%d\n", get());
> +	return sysfs_emit(buf, "%d\n", get());
>  }
>  
>  #define EEEPC_SENSOR_SHOW_FUNC(_name, _get)				\