linux-kernel - Re: [External] Re: [PATCH] riscv: add a warning when physical memory address overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fromgalp.fsf@bytedance.com>
Date: Wed, 23 Oct 2024 15:25:22 +0100
From: Punit Agrawal <punit.agrawal@...edance.com>
To: palmer@...belt.com
Cc: Alexandre Ghiti <alex@...ti.fr>,  punit.agrawal@...edance.com,
  paul.walmsley@...ive.com,  aou@...s.berkeley.edu,
  alexghiti@...osinc.com,  chenjiahao16@...wei.com,  guoren@...nel.org,
  vishal.moola@...il.com,  stuart.menefy@...asip.com,
  linux-riscv@...ts.infradead.org,  linux-kernel@...r.kernel.org, yunhui
 cui <cuiyunhui@...edance.com>
Subject: Re: [External] Re: [PATCH] riscv: add a warning when physical
 memory address overflows

Hi Palmer,

[...]

>> On 14/08/2024 08:26, Yunhui Cui wrote:
>> > The part of physical memory that exceeds the size of the linear mapping
>> > will be discarded. When the system starts up normally, a warning message
>> > will be printed to prevent confusion caused by the mismatch between the
>> > system memory and the actual physical memory.
>> >
>> > Signed-off-by: Yunhui Cui <cuiyunhui@...edance.com>
>> > ---
>> >   arch/riscv/mm/init.c | 8 ++++++--
>> >   1 file changed, 6 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> > index 52290c9bd04bd..c93164dc51658 100644
>> > --- a/arch/riscv/mm/init.c
>> > +++ b/arch/riscv/mm/init.c
>> > @@ -236,8 +236,12 @@ static void __init setup_bootmem(void)
>> >        */
>> >       if (IS_ENABLED(CONFIG_64BIT)) {
>> >               max_mapped_addr = __pa(PAGE_OFFSET) + KERN_VIRT_SIZE;
>> > -             memblock_cap_memory_range(phys_ram_base,
>> > -                                       max_mapped_addr - phys_ram_base);
>> > +             if (memblock_end_of_DRAM() > max_mapped_addr) {
>> > +                     memblock_cap_memory_range(phys_ram_base,
>> > +                                               max_mapped_addr - phys_ram_base);
>> > +                     pr_warn("Physical memory overflows the linear mapping size: region above 0x%llx removed",
>> > +                             max_mapped_addr);
>> > +             }
>> >       }
>> >
>> >
>>
>>
>> A bit weird to review and test my own patch, but here it is anyway :)
>>
>> Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>
>>
>> Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>

Looks like the patch has been ready for a while now. If there are no
further problems, can it be merged please?

[...]