linux-kernel - Re: [PATCH] Fix error in J1939 documentation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <306d6221-3cfa-4268-89f4-9331d69287e7@redhat.com>
Date: Wed, 23 Oct 2024 17:28:59 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Alexander Hölzl <alexander.hoelzl@....net>,
 robin@...tonic.nl, socketcan@...tkopp.net, mkl@...gutronix.de,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, corbet@....net
Cc: kernel@...gutronix.de, linux-can@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix error in J1939 documentation.

On 10/23/24 16:52, Alexander Hölzl wrote:
> The description of PDU1 format usage mistakenly referred to PDU2 format.
> 
> Signed-off-by: Alexander Hölzl <alexander.hoelzl@....net>
> ---
>  Documentation/networking/j1939.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> index e4bd7aa1f5aa..544bad175aae 100644
> --- a/Documentation/networking/j1939.rst
> +++ b/Documentation/networking/j1939.rst
> @@ -121,7 +121,7 @@ format, the Group Extension is set in the PS-field.
> 
>  On the other hand, when using PDU1 format, the PS-field contains a so-called
>  Destination Address, which is _not_ part of the PGN. When communicating a PGN
> -from user space to kernel (or vice versa) and PDU2 format is used, the PS-field
> +from user space to kernel (or vice versa) and PDU1 format is used, the PS-field
>  of the PGN shall be set to zero. The Destination Address shall be set
>  elsewhere.

You need to CC netdev or this patch will be lost,

Thanks,

Paolo