linux-kernel - Re: [PATCH v2 08/14] clk: rp1: Add support for clocks provided by RP1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241023183240.0dffae03@bootlin.com>
Date: Wed, 23 Oct 2024 18:32:40 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Andrea della Porta <andrea.porta@...e.com>
Cc: Stephen Boyd <sboyd@...nel.org>, Andrew Lunn <andrew@...n.ch>, Arnd
 Bergmann <arnd@...db.de>, Bartosz Golaszewski <brgl@...ev.pl>, Bjorn
 Helgaas <bhelgaas@...gle.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Catalin Marinas
 <catalin.marinas@....com>, Conor Dooley <conor+dt@...nel.org>, Derek
 Kiernan <derek.kiernan@....com>, Dragan Cvetic <dragan.cvetic@....com>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>, Linus Walleij
 <linus.walleij@...aro.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Luca
 Ceresoli <luca.ceresoli@...tlin.com>, Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>, Masahiro Yamada <masahiroy@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Rob Herring <robh@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>, St efan Wahren <wahrenst@....net>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Will Deacon
 <will@...nel.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 phil@...pberrypi.com, jonathan@...pberrypi.com
Subject: Re: [PATCH v2 08/14] clk: rp1: Add support for clocks provided by
 RP1

Hi Andrea,


On Wed, 23 Oct 2024 17:36:06 +0200
Andrea della Porta <andrea.porta@...e.com> wrote:

> Hi Stephen,
> 
> On 15:08 Wed 09 Oct     , Stephen Boyd wrote:
> > Quoting Andrea della Porta (2024-10-07 05:39:51)  
> > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > > index 299bc678ed1b..537019987f0c 100644
> > > --- a/drivers/clk/Kconfig
> > > +++ b/drivers/clk/Kconfig
> > > @@ -88,6 +88,15 @@ config COMMON_CLK_RK808
> > >           These multi-function devices have two fixed-rate oscillators, clocked at 32KHz each.
> > >           Clkout1 is always on, Clkout2 can off by control register.
> > >  
> > > +config COMMON_CLK_RP1
> > > +       tristate "Raspberry Pi RP1-based clock support"
> > > +       depends on PCI || COMPILE_TEST  
> > 
> > A better limit would be some ARCH_* config.  
> 
> I've avoided ARCH_BCM2835 since the original intention is for this driver
> to work (in the future) also for custom PCI cards with RP1 on-board, and not
> only for Rpi5.

Maybe depends on CONFIG_MISC_RP1 ?
CONFIG_MISC_RP1 enables the RP1 PCI driver

Best regards,
Hervé