linux-kernel - Re: [PATCH v3] selftests: add new kallsyms selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <368aa911-7a88-4a00-8830-4a183fd6f352@quicinc.com>
Date: Wed, 23 Oct 2024 10:28:49 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Luis Chamberlain <mcgrof@...nel.org>, <linux-modules@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <petr.pavlu@...e.com>,
        <samitolvanen@...gle.com>, <da.gomez@...sung.com>
CC: <masahiroy@...nel.org>, <deller@....de>, <linux-arch@...r.kernel.org>,
        <live-patching@...r.kernel.org>, <kris.van.hees@...cle.com>
Subject: Re: [PATCH v3] selftests: add new kallsyms selftests

On 10/21/24 12:33, Luis Chamberlain wrote:
...
> +gen_template_module_exit()
> +{
> +	cat <<____END_MODULE
> +static int __init auto_test_module_init(void)
> +{
> +	return auto_runtime_test();
> +}
> +module_init(auto_test_module_init);
> +
> +static void __exit auto_test_module_exit(void)
> +{
> +}
> +module_exit(auto_test_module_exit);
> +
> +MODULE_AUTHOR("Luis Chamberlain <mcgrof@...nel.org>");
> +MODULE_LICENSE("GPL");
> +____END_MODULE
> +}

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Is that a concern here?
Should we add a MODULE_DESCRIPTION()?

/jeff