linux-kernel - Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdb76466-3258-4c71-bca3-50fd3cc94a0e@kernel.org>
Date: Wed, 23 Oct 2024 19:49:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com,
 Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Peng Fan <peng.fan@....com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread
 spectrum clocking

On 23/10/2024 16:58, Dario Binacchi wrote:
>>>>
>>>> This is another commit [1] on enabling spread spectrum that I
>>>> implemented some time ago for
>>>> the am335x. The most evident difference is that in that case the node
>>>> was a clock node and not
>>>> a clock controller, as in the case of anatop. The parameters are also
>>>> not exactly the same, but
>>>> that depends on the platform.
>>>>
>>>> [1] 4a8bc2644ef0cbf8e ("dt-bindings: ti: dpll: add spread spectrum support")
>>>
>>>
>>> OK, I still do not know what "0" was, but the items are fixed, so you
>>> know exactly which clock you are configuring here.
>>
>> So, after delving deeper into the topic, is it now acceptable to use
>> the property
>> "fsl,ssc-clocks" instead of "clocks"?  As in the patch I applied locally?
> 
> A gentle ping.
> Sorry, but I haven't yet received your response to the previous email,
> and I'm not sure how to proceed.
> 

Yeah, the property is fine, but I don't think you need the clock index.
The lists - like clocks and your spread property - have strictly defined
items, so it is enough if schema lists items and says which spread
points to which clock.


P.S. I think you might pinged me on IRC, but you know,
https://nohello.net/en/


Best regards,
Krzysztof