linux-kernel - Re: [PATCH v2] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49a7dbae-d382-4b60-b08e-2aaca9eb343f@arm.com>
Date: Wed, 23 Oct 2024 09:49:07 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Sourav Panda <souravpanda@...gle.com>, akpm@...ux-foundation.org,
 surenb@...gle.com, yuzhao@...gle.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, pasha.tatashin@...een.com, weixugc@...gle.com
Subject: Re: [PATCH v2] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub


On 10/23/24 04:54, Sourav Panda wrote:
> alloc_tag_sub() takes bytes as opposed to number of pages as argument.
> 
> Currently pgalloc_tag_copy() passes the number of pages. This fix passes
> the correct unit, which is the number of bytes allocated.
> 
> Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()")
> Signed-off-by: Sourav Panda <souravpanda@...gle.com>
> Acked-by: Suren Baghdasaryan <surenb@...gle.com>
> Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>
> ---
> Changelog:
> Added Acked-by: Suren Baghdasaryan <surenb@...gle.com>
> Added Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>

Very minor nit.

Just mentioning that the tags have been picked up should suffice.

> Fixed the nit pointed by Wei in the commit message
> 
> v1:
> https://lore.kernel.org/all/20241022205622.133697-1-souravpanda@google.com/
> ---
>  include/linux/mm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index ecf63d2b0582..2890001c8b97 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *new, struct folio *old)
>  	/* Clear the old ref to the original allocation tag. */
>  	clear_page_tag_ref(&old->page);
>  	/* Decrement the counters of the tag on get_new_folio. */
> -	alloc_tag_sub(ref, folio_nr_pages(new));
> +	alloc_tag_sub(ref, folio_size(new));
>  
>  	__alloc_tag_ref_set(ref, tag);
>  

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>