linux-kernel - Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zxl3fB9FVz5i1huh@tiehlicka>
Date: Thu, 24 Oct 2024 00:23:56 +0200
From: Michal Hocko <mhocko@...e.com>
To: Dongjoo Seo <dongjoo.linux.dev@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, dave@...olabs.net,
	dan.j.williams@...el.com, nifan@...look.com,
	a.manzanares@...sung.com
Subject: Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes

On Wed 23-10-24 15:15:20, Dongjoo Seo wrote:
> Hi Andrew, Michal,
> 
> Thanks for the feedback.
> 
> The issue is that CPU-less nodes can lead to incorrect NUMA stats.
> For example, NUMA_HIT may incorrectly increase for CPU-less nodes
> because the current logic doesn't account for whether a node has CPUs.

Define incorrect

Current semantic doesn't really care about cpu less NUMA nodes because
current means whatever is required AFIU. This is certainly a long term
semantic. Why does this need to change and why it makes sense to 
pre-existing users?

-- 
Michal Hocko
SUSE Labs