linux-kernel - Re: [PATCH 1/1 perf-tools] perf python: Fix up the build on architectures without HAVE_KVM_STAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zxl41sigv9Fw7Vqv@x1>
Date: Wed, 23 Oct 2024 19:29:42 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 1/1 perf-tools] perf python: Fix up the build on
 architectures without HAVE_KVM_STAT_SUPPORT

On Wed, Oct 23, 2024 at 02:48:04PM -0700, Ian Rogers wrote:
> On Wed, Oct 23, 2024 at 2:46 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > On Wed, Oct 23, 2024 at 02:40:45PM -0700, Ian Rogers wrote:
> > > On Wed, Oct 23, 2024 at 2:05 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > > > Noticed while building on a raspbian arm 32-bit system.
<SNIP>
> > > > Fixes: 9dabf4003423c8d3 ("perf python: Switch module to linking libraries from building source")
> > > > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > > > Cc: Ian Rogers <irogers@...gle.com>
> > > > Cc: Jiri Olsa <jolsa@...nel.org>
> > > > Cc: Kan Liang <kan.liang@...ux.intel.com>
> > > > Cc: Namhyung Kim <namhyung@...nel.org>
> > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

> > > So this will at least conflict with:
> > > https://lore.kernel.org/lkml/20241022173015.437550-6-irogers@google.com/
> > > where the #ifdef-ed out functions are removed. Does that series fix
> > > the ARM32 issue? Could we land that?

> > I'd prefer to have what I posted for perf-tools, as it is smaller, and
> > to land the patch removing those functions on perf-tools-next.
 
> Makes sense to me. Have a
> Reviewed-by: Ian Rogers <irogers@...gle.com>
> should you need it.

Always appreciated, thanks, applying it to the patch,

- Arnaldo
 
> > I'll try to switch testing to a librecomputer board, the rpi3 is super
> > slow :-)