linux-kernel - Re: [PATCH] tools/mm: -Werror fixes in page-types/slabinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241023165115.b524c51e80c36e120edabb36@linux-foundation.org>
Date: Wed, 23 Oct 2024 16:51:15 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Wladislav Wiebe <wladislav.kw@...il.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Vlastimil Babka
 <vbabka@...e.cz>
Subject: Re: [PATCH] tools/mm: -Werror fixes in page-types/slabinfo

On Tue, 22 Oct 2024 19:21:13 +0200 Wladislav Wiebe <wladislav.kw@...il.com> wrote:

> Commit e6d2c436ff693 ("tools/mm: allow users to provide
> additional cflags/ldflags") passes now CFLAGS to Makefile.
> With this, build systems with default -Werror enabled found:
> 
> slabinfo.c:1300:25: error: ignoring return value of 'chdir'
> declared with attribute 'warn_unused_result' [-Werror=unused-result]
>                          chdir("..");
>                          ^~~~~~~~~~~
> page-types.c:397:35: error: format '%lu' expects argument of type
> 'long unsigned int', but argument 2 has type 'uint64_t'
> {aka 'long long unsigned int'} [-Werror=format=]
>                          printf("%lu\t", mapcnt0);
>                                  ~~^     ~~~~~~~
> ..
> 
> Fix page-types by using PRIu64 for uint64_t prints and check
> in slabinfo for return code on chdir("..").
> 

Thanks.

Your email client messed this up in strange ways, so I basically typed
it in again.  I added the Fixes: target and a cc:stable.