linux-kernel - Re: [RFC PATCH v1 08/10] net: qrtr: Drop remote {NEW|DEL}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2582b8af-e18d-4103-a703-4dbf7464746d@quicinc.com>
Date: Tue, 22 Oct 2024 17:36:11 -0700
From: Chris Lew <quic_clew@...cinc.com>
To: Denis Kenzior <denkenz@...il.com>, <netdev@...r.kernel.org>
CC: Marcel Holtmann <marcel@...tmann.org>, Andy Gross <agross@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v1 08/10] net: qrtr: Drop remote {NEW|DEL}_LOOKUP
 messages



On 10/18/2024 11:18 AM, Denis Kenzior wrote:
> These messages are explicitly filtered out by the in-kernel name
> service (ns.c).  Filter them out even earlier to save some CPU cycles.
> 
> Signed-off-by: Denis Kenzior <denkenz@...il.com>
> Reviewed-by: Marcel Holtmann <marcel@...tmann.org>
> Reviewed-by: Andy Gross <agross@...nel.org>
> ---
>   net/qrtr/af_qrtr.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/net/qrtr/af_qrtr.c b/net/qrtr/af_qrtr.c
> index b2f9c25ba8f8..95c9679725ee 100644
> --- a/net/qrtr/af_qrtr.c
> +++ b/net/qrtr/af_qrtr.c
> @@ -560,6 +560,11 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
>   	if (!size || len != ALIGN(size, 4) + hdrlen)
>   		goto err;
>   
> +	/* Don't allow remote lookups */
> +	if (cb->type == QRTR_TYPE_NEW_LOOKUP ||
> +	    cb->type == QRTR_TYPE_DEL_LOOKUP)
> +		goto err;
> +

Just curious, was this case observed? I thought we blocked clients from 
sending this control message to remotes and I didnt think the ns 
broadcasts it either.

>   	if ((cb->type == QRTR_TYPE_NEW_SERVER ||
>   	     cb->type == QRTR_TYPE_RESUME_TX) &&
>   	    size < sizeof(struct qrtr_ctrl_pkt))