linux-kernel - Re: [PATCH v2] kfifo: don't include dma-mapping.h in kfifo.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024102325-gone-reanalyze-f105@gregkh>
Date: Wed, 23 Oct 2024 08:01:04 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Christoph Hellwig <hch@....de>
Cc: jassisinghbrar@...il.com, stefani@...bold.net, jirislaby@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kfifo: don't include dma-mapping.h in kfifo.h

On Wed, Oct 23, 2024 at 07:53:04AM +0200, Christoph Hellwig wrote:
> Nothing in kfifo.h directly needs dma-mapping.h, only two macros
> use DMA_MAPPING_ERROR when actually instantiated.  Drop the
> dma-mapping.h include to reduce include bloat.
> 
> Add an explicity <linux/io.h> include to drivers/mailbox/omap-mailbox.c
> as that file uses __raw_readl and __raw_writel through a complicated
> include chain involving <linux/dma-mapping.h>
> 
> Fixes: d52b761e4b1a ("kfifo: add kfifo_dma_out_prepare_mapped()")
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
> 
> Changes since v1:
>  - improve the commit log

As the original commit came in through the tty tree, I'll take this through
the same tree as well.

thanks,

greg k-h